Do not bind the Management port into the generated Service resource #33694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to quarkusio#33307, task 4. Yet if users set the target-port to "management", this port won't be unbound.
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
Closed
4 tasks
Sgitario
changed the title
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
cescoffier
approved these changes
May 30, 2023
|
Is it something that should be backported to 3.1? |
|
@gsmet it can wait 3.2 |
Sgitario
added a commit
to Sgitario/quarkus
that referenced
this pull request
Jun 1, 2023
After quarkusio#33696 being merged, the port https is no longer bound by default. The problem is that I merged quarkusio#33694 without rebasing and these two tests needed to be updated.
sberyozkin
pushed a commit
to sberyozkin/quarkus
that referenced
this pull request
Jun 21, 2023
After quarkusio#33696 being merged, the port https is no longer bound by default. The problem is that I merged quarkusio#33694 without rebasing and these two tests needed to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #33307, task 4.
Yet if users set the "target-port" to "management", this port won't be unbound. I wanted to open this possibility to users that for some reason do want to expose the management port, so let me know what you think about this @iocanel @cescoffier